add test using composite pull filter on firestore #7482
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @agarcher |
|
Thanks for the response. I will look at fixing with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
When using the firestore replication, it is possible to use a composite filter if you use only one filter, but doing so causes typescript errors. The problem is that the pull options filter constrains to field filters only and according to firestore a composite filter is a different thing.
What I don't understand is that the code in the test does work if you throw an
as anyon there to tell typescript it's safe, but then we lose type safety. It would be great if the replication could relax the typing to allow a single composite key, but when I attempt to do that I wind up with type errors in the plugin source code where it performs the query. Some attempts to resolve the type issues led me to dead ends.